Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/avatar): add user-info to dropdown #1043

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Conversation

danielleroux
Copy link
Collaborator

🆕 What is the new behavior?

Add user info entry as first item of ix-avatar.
Do only working within a ix-application-header.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (yarn docs)
  • 🧪 Unit tests were added/updated and pass (yarn test)
  • 📸 Visual regression tests were added/updated and pass (yarn visual-regression)
  • 🧐 Static code analysis passes (yarn lint)
  • 🏗️ Successful compilation (yarn build, changes pushed)

👨‍💻 Help & support

@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Jan 12, 2024
@danielleroux danielleroux added this to the 2.1.0 milestone Jan 12, 2024
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSDocs

packages/core/src/components/avatar/avatar.tsx Outdated Show resolved Hide resolved
packages/core/src/components/avatar/avatar.tsx Outdated Show resolved Hide resolved
danielleroux and others added 3 commits January 15, 2024 15:17
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
@danielleroux danielleroux merged commit 01a0093 into main Jan 16, 2024
6 checks passed
@danielleroux danielleroux deleted the feat/user-info branch January 16, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants