Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/dropdown): check submenu item by interface #1060

Merged
merged 8 commits into from
Feb 6, 2024

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: Closes #895

What is the new behavior?

All internal dropdown-item wrapper components have to implement the DropdownItemWrapper interface. This ensures that the features like sub menu icon can be activated.

Does this introduce a breaking change?

  • Yes
  • No

Other information

#919 will be closes because of a stale branch

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Jan 30, 2024
@danielleroux danielleroux added this to the 2.1.0 milestone Jan 30, 2024
@danielleroux danielleroux self-assigned this Jan 30, 2024
@nuke-ellington nuke-ellington merged commit 4a95af8 into main Feb 6, 2024
6 checks passed
@danielleroux danielleroux deleted the fix/dropdown-menu-wrapper branch September 5, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ix-dropdown trigger in combination with ix-menu-avatar-item does not work
2 participants