Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/message-bar): remove unwanted margin #1064

Merged
merged 17 commits into from
Feb 22, 2024
Merged

Conversation

matthiashader
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@nuke-ellington nuke-ellington added this to the 2.2.0 milestone Feb 9, 2024
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since a list of message bars should have vertical margins of 0.5rem between the individual bars we should replace the
tags with actual margins in the examples.
This will better illustrate the usage to the users.
Also removing the built-in margins is kind of like a breaking change IMO?

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the proposed changes all examples should have 0.5rem instead of 1.25rem as margin values.

@nuke-ellington nuke-ellington merged commit 62b7565 into main Feb 22, 2024
6 checks passed
@danielleroux danielleroux modified the milestones: 2.2.0, 2.1.1 Feb 22, 2024
@nuke-ellington nuke-ellington added the pull request affects patch version The pull request affects only patch version label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants