Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/menu-category): allow empty icon as menu-category-item #1110

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Feb 22, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

UI changes.

What is the current behavior?

The second level navigation has a default icon defined. Icons on the second level are required. No ellipsis for menu-category.

GitHub Issue Number: N/A

What is the new behavior?

The second level navigation no longer has a default/required icon. Ellipsis for menu-category added.

Does this introduce a breaking change?

  • Yes
  • No

It is not a breaking change, but the default icon if currently visible is no longer shown.

Testing

Manual tests.

Other information

@jul-lam jul-lam self-assigned this Feb 22, 2024
@jul-lam jul-lam marked this pull request as draft February 22, 2024 14:29
@danielleroux danielleroux changed the title Fix/empty icon on second level navigation fix(core/menu-category): allow empty icon as menu-category-item Feb 23, 2024
@jul-lam jul-lam added this to the 2.1.1 milestone Feb 23, 2024
@jul-lam jul-lam marked this pull request as ready for review February 23, 2024 08:35
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Feb 23, 2024
@danielleroux danielleroux merged commit 03790e0 into main Feb 26, 2024
6 checks passed
@danielleroux danielleroux deleted the fix/empty-icon-on-second-level-navigation branch February 26, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants