Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/select-item): Fixes inherit color #1160

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Mar 13, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When surrounding the ix-select with a div (with color styled to e.g red) it gets inherited by the children.

GitHub Issue Number: N/A

What is the new behavior?

The color of the surrounding area not getting inherited by the dropdown-items anymore.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@matthiashader matthiashader linked an issue Mar 13, 2024 that may be closed by this pull request
2 tasks
@nuke-ellington nuke-ellington added the pull request affects patch version The pull request affects only patch version label Mar 13, 2024
@nuke-ellington nuke-ellington added this to the 2.1.2 milestone Mar 13, 2024
@nuke-ellington nuke-ellington merged commit b9fb01d into main Mar 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select items inherit colour
2 participants