Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/modal): update header alignment #217

Merged
merged 2 commits into from
Dec 5, 2022
Merged

fix(core/modal): update header alignment #217

merged 2 commits into from
Dec 5, 2022

Conversation

nuke-ellington
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@nuke-ellington nuke-ellington added type: bug Something isn't working component: core pull request affects patch version The pull request affects only patch version labels Dec 5, 2022
@nuke-ellington nuke-ellington linked an issue Dec 5, 2022 that may be closed by this pull request
Modal header alignment is wrong #208
Closed
danielleroux
danielleroux approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 83391ba into main Dec 5, 2022
@danielleroux danielleroux deleted the 208-modal-header-alignment-is-wrong branch December 5, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal header alignment is wrong
2 participants
@nuke-ellington @danielleroux