Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/tree-item): allow child elements to receive pointer events #369

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix(core/tree-item): allow child elements to receive pointer events #369

merged 1 commit into from
Feb 14, 2023

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Feb 9, 2023 •
edited by danielleroux
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@nuke-ellington nuke-ellington linked an issue Feb 9, 2023 that may be closed by this pull request
Checkbox inside tree item does not trigger change event #318
Closed
danielleroux
danielleroux approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit ed43a53 into main Feb 14, 2023
@danielleroux danielleroux deleted the 318-checkbox-inside-tree-item-does-not-trigger-change-event branch February 14, 2023 07:11
@danielleroux danielleroux added this to the 1.4.0 milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Checkbox inside tree item does not trigger change event
2 participants
@nuke-ellington @danielleroux