Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/tooltip): remove arrow if not visible #451

Merged
merged 4 commits into from
Mar 20, 2023
Merged

fix(core/tooltip): remove arrow if not visible #451

merged 4 commits into from
Mar 20, 2023

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Mar 16, 2023 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • stencil hydration overwrites visibility property
  • Arrow is all the time clickable which prevent the hover event
  • change position strategy from absolute to fix to handle overflows better

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Mar 16, 2023
@danielleroux danielleroux added this to the 1.4.2 milestone Mar 16, 2023
@danielleroux danielleroux linked an issue Mar 16, 2023 that may be closed by this pull request
ix tooltips don't disappear completely #450
Closed
nuke-ellington
nuke-ellington approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 6d02372 into main Mar 20, 2023
@danielleroux danielleroux deleted the 450-ix-tooltips-dont-disappear-completely branch March 20, 2023 09:53
danielleroux added a commit that referenced this pull request Mar 20, 2023
@danielleroux
fix(core/tooltip): remove arrow if not visible (#451)
368a240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

ix tooltips don't disappear completely
2 participants
@danielleroux @nuke-ellington