Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IxButton] Changing children of a button throws NotFoundError #503

Closed
robert-wettstaedt opened this issue May 3, 2023 · 2 comments
Closed
Labels
type: bug Something isn't working
Milestone

Comments

@robert-wettstaedt
Copy link
Contributor

What happened?

Changing or replacing the children of a button yields the following error:

NotFoundError

Node.removeChild: The node to be removed is not a child of this node

▼ 21 stack frames were expanded.
removeChild
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:11099:18

commitDeletionEffectsOnFiber
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24028:26

commitDeletionEffects
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:23976:33

recursivelyTraverseMutationEffects
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24259:30

commitMutationEffectsOnFiber
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24346:43

recursivelyTraverseMutationEffects
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24273:35

commitMutationEffectsOnFiber
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24332:43

recursivelyTraverseMutationEffects
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24273:35

commitMutationEffectsOnFiber
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24293:43

recursivelyTraverseMutationEffects
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24273:35

commitMutationEffectsOnFiber
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24293:43

recursivelyTraverseMutationEffects
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24273:35

commitMutationEffectsOnFiber
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24576:43

recursivelyTraverseMutationEffects
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24273:35

commitMutationEffectsOnFiber
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24432:43

commitMutationEffects
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:24243:31

commitRootImpl
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:26810:26

commitRoot
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:26682:19

performSyncWorkOnRoot
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:26117:13

flushSyncCallbacks
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:12042:22

ensureRootIsScheduled/<
https://0wz3rg.codesandbox.io/node_modules/react-dom/cjs/react-dom.development.js:25651:13

What type of frontend frameware are you seeing the problem on?

React

Which version of iX do you use?

v1.4.2

Code to produce this issue.

https://codesandbox.io/s/changing-children-of-a-ixbutton-throws-notfounderror-9iq2zj
@robert-wettstaedt robert-wettstaedt added the triage We discuss this topic in our internal weekly label May 3, 2023
@danielleroux
Copy link
Collaborator

danielleroux commented May 4, 2023

@robert-wettstaedt This is a known problem regarding react and stenciljs-webcomponents which dont use shadowDOM as the encapsulation. Its planned to migrate the components to shadowDOM components then the ugly workround with an addional child wrapper is not necessary.

#138
#511

@danielleroux danielleroux added type: bug Something isn't working component: core and removed triage We discuss this topic in our internal weekly labels May 25, 2023
@danielleroux danielleroux added this to the 1.7.0 milestone May 25, 2023
@danielleroux
Copy link
Collaborator

danielleroux commented Aug 15, 2023

Fixed with #534

@danielleroux danielleroux modified the milestones: 1.7.0, 2.0.0 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants