Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/map-navigation): expose method to change visibility of sidebar #550

Merged
merged 3 commits into from
May 25, 2023
Merged

feat(core/map-navigation): expose method to change visibility of sidebar #550

merged 3 commits into from
May 25, 2023

Conversation

goncalosard
Copy link
Contributor

@goncalosard goncalosard commented May 25, 2023 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: closing #531

Does this introduce a breaking change?

  • Yes
  • No

@goncalosard goncalosard linked an issue May 25, 2023 that may be closed by this pull request
IxMenu (MapNavigation) -> toggleMapExpand does not hide sidebar content #531
Closed
@danielleroux danielleroux changed the title feat: sidebar toggle feat(core/map-navigation): expose method to change visibility of sidebar May 25, 2023
@danielleroux danielleroux added this to the 1.6.0 milestone May 25, 2023
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label May 25, 2023
nuke-ellington
nuke-ellington approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit da52729 into main May 25, 2023
@danielleroux danielleroux deleted the feat/external-map-sidebar-toggle branch May 25, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

@danielleroux danielleroux Awaiting requested review from danielleroux

Assignees
No one assigned
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

IxMenu (MapNavigation) -> toggleMapExpand does not hide sidebar content
3 participants
@goncalosard @nuke-ellington @danielleroux