-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/button) loading state #583
Conversation
packages/angular-test-app/src/preview-examples/button-loading.ts
Outdated
Show resolved
Hide resolved
packages/angular-test-app/src/preview-examples/button-loading.ts
Outdated
Show resolved
Hide resolved
@nuke-ellington @danielleroux New loading button was added with the new props. Documentation examples were also added. |
Changed the PR to a breaking change. I have replaced the spinner animation with a new one which fits better into the library. Final adaptions regarding the animation will be done maybe later on. Removed the type from the interface of the spinner Add a breaking change section to the document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
[IX-250]
What is the new behavior?
Does this introduce a breaking change?