Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/button) loading state #583

Merged
merged 8 commits into from
Jun 28, 2023
Merged

feat(core/button) loading state #583

merged 8 commits into from
Jun 28, 2023

Conversation

goncalosard
Copy link
Contributor

@goncalosard goncalosard commented Jun 15, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

[IX-250]

What is the new behavior?

  • Added loading button example to Button documentation

Does this introduce a breaking change?

  • Yes
  • No

@goncalosard
Copy link
Contributor Author

@nuke-ellington @danielleroux New loading button was added with the new props. Documentation examples were also added.
No VRT was added because of moving spinner, making it always fail.

@danielleroux danielleroux changed the title feat(documentation/button) loading button example feat(core/button) loading state Jun 27, 2023
@danielleroux danielleroux self-assigned this Jun 28, 2023
@danielleroux danielleroux removed their request for review June 28, 2023 11:45
@danielleroux danielleroux added this to the 2.0.0 milestone Jun 28, 2023
@danielleroux danielleroux added the pull request affects major version The pull request affects only major version label Jun 28, 2023
@danielleroux
Copy link
Collaborator

Changed the PR to a breaking change.

I have replaced the spinner animation with a new one which fits better into the library. Final adaptions regarding the animation will be done maybe later on.

Removed the type from the interface of the spinner

Add a breaking change section to the document.

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 2c5b183 into main Jun 28, 2023
@danielleroux danielleroux deleted the feat/loading-button branch June 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects major version The pull request affects only major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants