Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/modal): migrate to shadow dom #648

Merged
merged 25 commits into from
Jul 27, 2023
Merged

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Jul 21, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #511 #507

What is the new behavior?

  • Replace custom modal implementation with HTMLDialog
  • Add ix-modal-header, ix-modal-content, ix-model-footer to handle layouting more structured
  • Add showMessage function to show default messages (into, success, warning, error, question)
  • Add showModalLoading to loading spinner as modal
  • Enhance documentation regarding new functionality
  • Add JSDocs to all empty Prop/Event decorators

Does this introduce a breaking change?

  • Yes, see BREAKING_CHANGES.md
  • No

@danielleroux danielleroux added the pull request affects major version The pull request affects only major version label Jul 21, 2023
@danielleroux danielleroux added this to the 2.0.0 milestone Jul 21, 2023
@danielleroux danielleroux changed the title feat(core/modal): rework feat(core/modal): migrate to shadow dom Jul 21, 2023
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tings

BREAKING_CHANGES.md Outdated Show resolved Hide resolved
BREAKING_CHANGES.md Outdated Show resolved Hide resolved
BREAKING_CHANGES.md Outdated Show resolved Hide resolved
BREAKING_CHANGES.md Outdated Show resolved Hide resolved
packages/core/src/components/modal/modal.tsx Outdated Show resolved Hide resolved
packages/core/src/components/modal/modal.tsx Outdated Show resolved Hide resolved
packages/documentation/docs/controls/modal.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/modal.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/modal.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/modal.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 0421bf5 into main Jul 27, 2023
7 checks passed
@danielleroux danielleroux deleted the feat/modal-shadow-dom branch July 27, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects major version The pull request affects only major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants