Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IxMenuItem] Allow rendering of custom icons #711

Closed
robert-wettstaedt opened this issue Aug 18, 2023 · 4 comments · Fixed by #778
Closed

[IxMenuItem] Allow rendering of custom icons #711

robert-wettstaedt opened this issue Aug 18, 2023 · 4 comments · Fixed by #778
Labels
Documentation Improvements or additions to documentation type: enhancement New feature or request
Milestone

Comments

@robert-wettstaedt
Copy link
Contributor

Suggestion / feature request

There are a lot of feature requests to add icons to the industrial icon pack.

Even more can be found in the repo of the icons package.

I think some of them could be avoided if there was a possibility to render custom icons in iX. Right now, I believe the navigation is the only place where there is no workaround for this.

So I suggest adding a slot with the name icon that will be rendered instead of the default IxIcon, such as:

<IxBasicNavigation>
  <IxMenu>
    <ixMenuItem> 
      <slot name="icon">
        <svg><path d="..."/></svg>
      </slot>
      
      Item 1
    </IxMenuItem>
  </IxMenu>
</IxBasicNavigation>
@robert-wettstaedt robert-wettstaedt added triage We discuss this topic in our internal weekly type: enhancement New feature or request labels Aug 18, 2023
@danielleroux
Copy link
Collaborator

Thanks for your idea!
We already talked alot about this topic. We planning to provide a functionality to use custom SVG inside our components. This will be part of the upcoming 2.0.0 release.

@danielleroux danielleroux added Documentation Improvements or additions to documentation component: core and removed triage We discuss this topic in our internal weekly labels Aug 18, 2023
@danielleroux danielleroux added this to the 2.0.0 milestone Aug 18, 2023
@robert-wettstaedt
Copy link
Contributor Author

Sounds good! Is there anything that can be tested in the current 2.0.0 beta already?

@danielleroux
Copy link
Collaborator

Not in the latest beta. My plan is to release a new beta mid/end of next week. I hope until then we can a least provide the functionality for custom svg icons but without a documentation.

@seb-spang
Copy link

seb-spang commented Aug 18, 2023

This enhancement would be very appreciated by my team as well. In particular being able to render custom SVGs inside an IxIconButton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants