Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/input): add basic input styling #717

Merged
merged 12 commits into from
Aug 25, 2023
Merged

feat(core/input): add basic input styling #717

merged 12 commits into from
Aug 25, 2023

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number:

Closes #138
Closes #716

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux danielleroux added the pull request affects major version The pull request affects only major version label Aug 21, 2023
@danielleroux danielleroux added this to the 2.0.0 milestone Aug 21, 2023
@danielleroux danielleroux changed the title Feat/ix inputs feat(core/input): add basic input styling Aug 21, 2023
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos

packages/core/src/components/input-group/input-group.tsx Outdated Show resolved Hide resolved
packages/core/src/components/input-group/input-group.tsx Outdated Show resolved Hide resolved
packages/core/scss/components/form/_input.scss Outdated Show resolved Hide resolved
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux marked this pull request as ready for review August 22, 2023 11:15
@danielleroux danielleroux merged commit 429f39e into main Aug 25, 2023
7 checks passed
@danielleroux danielleroux deleted the feat/ix-inputs branch September 5, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects major version The pull request affects only major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text area overflow hidden remove bootstrap dependency
2 participants