Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/dropdown-item): mark dropdown-item as internal event #761

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

  • Mark itemClick as internal event.

@danielleroux danielleroux added the pull request affects major version The pull request affects only major version label Sep 13, 2023
@danielleroux danielleroux added this to the 2.0.0 milestone Sep 13, 2023
nuke-ellington
nuke-ellington previously approved these changes Sep 14, 2023
@danielleroux danielleroux changed the title feat(core/dropdown-item): mark dropdown-item as intenral event feat(core/dropdown-item): mark dropdown-item as internal event Sep 14, 2023
@danielleroux danielleroux merged commit b9d4804 into main Sep 14, 2023
7 checks passed
@danielleroux danielleroux deleted the feat/dropdown-item branch September 14, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects major version The pull request affects only major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants