Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/card): add primary variant #780

Merged
merged 4 commits into from
Sep 26, 2023
Merged

feat(core/card): add primary variant #780

merged 4 commits into from
Sep 26, 2023

Conversation

nuke-ellington
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

danielleroux
danielleroux previously approved these changes Sep 25, 2023
@danielleroux danielleroux modified the milestones: 2.1.0, 2.0.0 Sep 26, 2023
@danielleroux danielleroux merged commit c47a9c2 into main Sep 26, 2023
7 checks passed
@danielleroux danielleroux deleted the feat/card-primary branch September 26, 2023 11:04
nuke-ellington added a commit that referenced this pull request Nov 20, 2023
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants