Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/select): filter corrections #784

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: closes #773

What is the new behavior?

  • Opening dropdown no longer resets the value typed by the user before opening.
  • User is now able to tab into the select, type and then open the dropdown, where the filter works correctly
  • If user types when dropdown is open, then if dropdown is closed and re-opened, filter works correctly with what was typed before.

Does this introduce a breaking change?

  • Yes
  • No

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem fine but the original issue states that the dropdown should open if the user starts typing. This is not adressed yet. Also consider adding unit tests for these scenarios.

@nuke-ellington nuke-ellington self-assigned this Oct 20, 2023
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Oct 20, 2023
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In closed PR #849, was the following issue adressed #773 which is not solved here.

@nuke-ellington
Copy link
Collaborator

In closed PR #849, was the following issue adressed #773 which is not solved here.

This is not the expected behavior (confirmed by UX).

@nuke-ellington nuke-ellington merged commit 3767fce into main Oct 31, 2023
7 checks passed
@danielleroux danielleroux modified the milestones: 2.1.0, 2.0.4 Nov 6, 2023
nuke-ellington added a commit that referenced this pull request Nov 20, 2023
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ix-select] When tabbing into an ix-select, the dropdown options don't show up
3 participants