Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centered property is not working properly of Modal component #794

Closed
viktorhajer opened this issue Oct 2, 2023 · 2 comments · Fixed by #836
Closed

Centered property is not working properly of Modal component #794

viktorhajer opened this issue Oct 2, 2023 · 2 comments · Fixed by #836
Assignees
Labels
type: bug Something isn't working

Comments

@viktorhajer
Copy link

What happened?

If the centered property is true, then the header of the modal is positioned to the center of the page (not the whole dialog).

What type of frontend frameware are you seeing the problem on?

Angular

Which version of iX do you use?

v2.0.1

Code to produce this issue.

this.modalService.open({
      content: DialogComponent,
      title: 'title',
      size: '840',
      centered: true
    });
@viktorhajer viktorhajer added the triage We discuss this topic in our internal weekly label Oct 2, 2023
@danielleroux
Copy link
Collaborator

Can not reproduce the issue. Please provide a repository to reproduce alternative checkout the stackblitz here: https://stackblitz.com/edit/6rvsz2?file=src%2Fapp%2Fmodal-by-template.ts

@viktorhajer
Copy link
Author

I've just updated the content of the in your code to have a little bit higher content:

<ng-template #customModal let-modal> <div style="height: 500px">xx</div> </ng-template>

image

@danielleroux danielleroux self-assigned this Oct 11, 2023
@danielleroux danielleroux added type: bug Something isn't working and removed triage We discuss this topic in our internal weekly labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants