Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/event-list-item): fix right padding #859

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Oct 19, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@matthiashader matthiashader linked an issue Oct 19, 2023 that may be closed by this pull request
Copy link

@collins-k collins-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer to use the padding-inline property as a shortcut for defining left and right padding

@danielleroux danielleroux added this to the 2.1.0 milestone Oct 20, 2023
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Oct 20, 2023
@nuke-ellington nuke-ellington merged commit f58cc97 into main Oct 31, 2023
7 checks passed
@danielleroux danielleroux modified the milestones: 2.1.0, 2.0.4 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing spacing for event-list-item-container
4 participants