Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/tabs): flickering #890

Merged
merged 8 commits into from
Nov 6, 2023
Merged

fix(core/tabs): flickering #890

merged 8 commits into from
Nov 6, 2023

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Nov 2, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

  • the lower bar does not appear at start --> changed lifecycle

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@matthiashader matthiashader linked an issue Nov 6, 2023 that may be closed by this pull request
@nuke-ellington nuke-ellington merged commit bded378 into main Nov 6, 2023
7 checks passed
@nuke-ellington nuke-ellington added the pull request affects patch version The pull request affects only patch version label Nov 8, 2023
@nuke-ellington nuke-ellington added this to the 2.0.4 milestone Nov 8, 2023
nuke-ellington added a commit that referenced this pull request Nov 20, 2023
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ix-tabs flashing on navigation
2 participants