Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): eol uniformization #148

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix(core): eol uniformization #148

merged 1 commit into from
Nov 17, 2022

Conversation

PhentomPT
Copy link
Contributor

Summary

When running build for the @siemens/ix package the file component-doc.json generates its content eol based on the users system.
To uniformize the content from win/unix systems i added a search replace "\r" -> ""

How did you test this change?

Runned the build command on both unix & win systems and the output is the same

Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 8088522 into main Nov 17, 2022
@danielleroux danielleroux deleted the fix/component-doc-eol branch November 17, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

markdown file which generate on windows machines have other eol
2 participants