Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTORING] : introduce const MAPPER_DEFAULT #18

Closed
Siemienik opened this issue Oct 1, 2020 · 4 comments · Fixed by #19
Closed

[REFACTORING] : introduce const MAPPER_DEFAULT #18

Siemienik opened this issue Oct 1, 2020 · 4 comments · Fixed by #19
Labels
good first issue Good for newcomers

Comments

@Siemienik
Copy link
Owner

Actual

Current default mapper is defined implicitly in two places:
https://github.com/Siemienik/xlsx-import/blob/be72568ed68b1922c81731e45beecd89c3283ce9/src/Importer.ts#L22
https://github.com/Siemienik/xlsx-import/blob/be72568ed68b1922c81731e45beecd89c3283ce9/src/Importer.ts#L41

Expected

The default mapper should be defined explicitly as a const MAPPER_DEFAULT (or some name like that)

@Siemienik Siemienik added help wanted good first issue Good for newcomers and removed help wanted labels Oct 1, 2020
@cmwalshWVU
Copy link

Hi I would like to work this issue for you. Can I please have write access to this project to push my branch? Thank you

@Siemienik
Copy link
Owner Author

@cmwalshWVU

Hi I would like to work this issue for you. Can I please have write access to this project to push my branch? Thank you

Hi, I nice to hear that :) it is awesome, that some other peoples than me wants to contribute this project ❤️

I can not give you write access, however you have a possibility to fork repo by the button on up&right display corner

image

Then this repo should be clone on your profiles, with fully write access for you. (probably hosted as cmwalshWVU/xlsx-import). There It is recommend to commit changes into new branch.

Finally, when your fix is done and all commits pushed, please go to "Pull requests" and create new one targeting to this repo.

@lowkeypriority @cmwalshWVU Thank you again for contributing this library :)

If you want, I may create more well described issues here and on siemienik/xlsx-renderer labeled 'good first issue' . What do you think?

@lowkeypriority
Copy link
Contributor

lowkeypriority commented Oct 2, 2020

Thank you again for contributing this library :)

@Siemienik Thank you.

If you want, I may create more well described issues here and on siemienik/xlsx-renderer labeled 'good first issue'

It would be great if you could do this. This will make it easier to contribute and implement your ideas :)

@Siemienik
Copy link
Owner Author

Siemienik commented Oct 2, 2020

I've created issue with list of mappers to develop: #21
Imo mappers are perfect for good first issues

Repository owner locked as resolved and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants