Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dateMapper into mappers #58

Closed
4 tasks done
Siemienik opened this issue Oct 20, 2020 · 0 comments · Fixed by #192
Closed
4 tasks done

Add dateMapper into mappers #58

Siemienik opened this issue Oct 20, 2020 · 0 comments · Fixed by #192
Assignees
Labels
accepted It is accepted to do good first issue Good for newcomers

Comments

@Siemienik
Copy link
Owner

Siemienik commented Oct 20, 2020

Part of #21

TODO:

  1. Create file src/mappers/dateMapper.ts with function matches to type ValueMapper<Date>. Which parse value string into Date.
  2. reexport it in src/mappers/index.ts
  3. Prove that it works in unit test (some present dates, some future, some past & some invalid)
  4. Describe it in Readme.md

tips:

  • ExcelJS used inside xlsx-import return Date strings created by new Date().toString()
    fi. Thu Oct 08 2020 02:00:00 GMT+0200 (Central European Summer Time)

For making a reservation please open draft PR with this issue linked

@Siemienik Siemienik added the good first issue Good for newcomers label Oct 20, 2020
@Siemienik Siemienik added the accepted It is accepted to do label Nov 1, 2020
@Siemienik Siemienik self-assigned this Aug 29, 2021
Siemienik added a commit to Siemienik/siemienik.github.io that referenced this issue Sep 27, 2021
Siemienik added a commit to Siemienik/siemienik.github.io that referenced this issue Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted It is accepted to do good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant