crt0: make argv 8-byte aligned #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuchingy
approved these changes
May 13, 2021
issuehsu
force-pushed
the
fix-unaligned-argv
branch
from
4fe550e
to
5a8cfb3
Compare
issuehsu
force-pushed
the
fix-unaligned-argv
branch
from
5a8cfb3
to
79d0422
Compare
DavidSTWChen
requested review from
paul-walmsley-sifive and
sifive-eblot
as code owners
|
@DavidSTWChen , we can merge this, it's no problem; just one question. Does this patch also need to be applied to the toolchain libgloss as well and sent to the toolchain team? i.e., https://github.com/sifive/riscv-newlib/blob/sifive-newlib-2021.04-release/libgloss/riscv/crt0.S OIn the FESDK side, we will also have to apply this one to the new release_generator_mongoose branch; we can probably take care of that on our side. |
|
@paul-walmsley-sifive The assumption for newlib/libgloss is: argv are prepared by the execution environment like simulator, so the execution environment has responsibility to make sure that. In another word: I think we don't need similar change on newlib/libgloss side :) |
lexus0
added a commit
that referenced
this pull request
Jun 25, 2021
The original one is align 8, but there is patch to modify it. #374 The e76, and s76 will drop with above patch for coremark. This patch makes balign, and align work together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.