Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger_error on genurl action parameter invalid value set #60

Merged
merged 1 commit into from
Mar 29, 2014

Conversation

JavierCane
Copy link
Member

Notice developer through a trigger_error about unintentional 'action' genurl function parameter override if he doesn't specify a valid value.

…'action' genurl function parameter override if he doesn't specify a valid value.
@JavierCane
Copy link
Member Author

Quidisir:

Se puede dar el caso en el que le especifiquemos como parsed_param un parámetro con key "action", que nada tenga que ver con el parámetro que usamos en el plugin de forma interna para el tema de saber qué lógica aplicar con cada uno de los parsed_params.

Para intentar detectar esto e informar de alguna manera, si vemos que el action tiene un valor fuera de los posibles (add, replace, remove), lanzamos un trigger_error.

alombarte added a commit that referenced this pull request Mar 29, 2014
trigger_error on genurl action parameter invalid value set
@alombarte alombarte merged commit 332a039 into sifophp:devel Mar 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants