Multiple improvements from Uvinum's fork #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
obokaman-com
commented
Apr 4, 2017
obokaman-com
commented
- Additional check to identify secure environment (HTTP_X_FORWARDED_PROTO)
- Additional check for NR integration (doesn't overwrite app's name if it has been defined in VH)
- Doesn't extend View class from Smarty: now it composes with Smarty or Twig, depending on template extension.
- Increase from 1 to 3 as parsed param keys
- Fix on Bootstrap::includeFile to prevent multiple includes on multi-release deploy environments
- Additional tags for dependency injection definition configs (to allow event subscribers, for instance)
…'re under https protocol request
Use VH variable to define New Relic app name Add check of HTTP_X_FORWARDED_PROTO == 'https' in order to detect you're under https protocol request
…production environments with release folders and symlinks: when one script is running during a deployment, autoload could try to include a new file, since its physical location has changed in the new release. Now `Bootstrap::includeFile` (used by SIFO autoload) only try to include a file if it doesn’t exists in the current execution thread yet.
… parameters.
e.g:
tags:
- { name: event_subscriber }
will write:
$config['tags']['event_subscriber’][‘service_name’] = [];
… parameters. e.g: tags: - { name: event_subscriber } will write: $config['tags']['event_subscriber’][‘service_name’] = [];
… parameters. e.g: tags: - { name: event_subscriber } will write: $config['tags']['event_subscriber’][‘service_name’] = [];
added 6 commits
April 12, 2017 09:52
…t exists Twig adapter fix for PHP 7.1 Remove PHPMailer, phpunit-skeleton-generator and PHPUnit libraries inside SIFO code Update twig and yaml version dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.