Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added --distro-patches flag #511

Merged

Conversation

Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Apr 30, 2024

usage: --distro-patches go-getter/compatible/path

Within the location, the folders must have the target KFD version as name (e.g. v1.29.0) and the contents should be compatible with those from the https://github.com/sighupio/fury-distribution repository.

closes #503

@Al-Pragliola Al-Pragliola self-assigned this Apr 30, 2024
@Al-Pragliola Al-Pragliola added the enhancement New feature or request label Apr 30, 2024
@Al-Pragliola Al-Pragliola marked this pull request as ready for review April 30, 2024 16:48
@Al-Pragliola Al-Pragliola force-pushed the feature/invalidate-cache-on-download-fail branch from 8504d60 to 3cbce42 Compare May 3, 2024 11:53
Base automatically changed from feature/invalidate-cache-on-download-fail to feature/april-improvements May 3, 2024 11:56
@Al-Pragliola Al-Pragliola merged commit 992b0b0 into feature/april-improvements May 3, 2024
1 check passed
@Al-Pragliola Al-Pragliola deleted the feature/distro-patches-flag branch May 3, 2024 12:04
Al-Pragliola added a commit that referenced this pull request May 3, 2024
* feat: added --distro-patches flag

* fix: switch from error to warn when not finding a version in custom patches location
Al-Pragliola added a commit that referenced this pull request May 3, 2024
* feat: move binaries and cache to outdir if present (#506)

* feat: cache invalidation on download fail (#509)

* feat: cache invalidation on download fail

* fix: linting

* fix: e2e tests

* fix: delete cache folder after parallel download are finished on error

* feat: added --distro-patches flag (#511)

* feat: added --distro-patches flag

* fix: switch from error to warn when not finding a version in custom patches location

* feat: improve UX in config creations sub cmd (#512)

* feat: improve UX in config creations sub cmd

* fix: e2e test

* feat: added get kubeconfig sub command (#513)

* feat: added get config sub command

* chore: added success message

* fix: --distro-patches not accepting relative paths + does not clear his cache on error

* fix: linting

* chore: improve help message for --distro-patches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant