Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure a valid github profile is chosen. #40

Merged
merged 1 commit into from
Dec 16, 2014
Merged

Conversation

mrwacky42
Copy link
Contributor

I was seeing the following error when I had more than one github profile:

Invalid slot type: gh-gist-api, :base, string, nil

I tracked it down to this completing-read not requiring valid input.
This change makes it so:

  • If the user inputs nothing, it returns the first profile in the list.
  • The choice must be in the list of profiles.

Meanwhile, for people using ido-ubiquitous, this is also an acceptable
workaround:

(setq ido-ubiquitous-enable-old-style-default nil)

I was seeing the following error when I had more than one github profile:

    Invalid slot type: gh-gist-api, :base, string, nil

I tracked it down to this completing-read not requiring valid input.
This change makes it so:
* If the user inputs nothing, it returns the first profile in the list.
* The choice must be in the list of profiles.

Meanwhile, for people using ido-ubiquitous, this is also an acceptable
workaround:

(setq ido-ubiquitous-enable-old-style-default nil)
sigma added a commit that referenced this pull request Dec 16, 2014
Ensure a valid github profile is chosen.
@sigma sigma merged commit c4cf139 into sigma:master Dec 16, 2014
colonelpanic8 pushed a commit to colonelpanic8/gh.el that referenced this pull request Jun 17, 2016
Ensure a valid github profile is chosen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants