Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/split cli admin #31

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Chore/split cli admin #31

merged 3 commits into from
Feb 1, 2024

Conversation

ppoliani
Copy link
Contributor

Fixes #13.

A simpler version of #24

@ppoliani ppoliani mentioned this pull request Jan 30, 2024
Closed
mimoo
mimoo approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@mimoo mimoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One question though, will the README.md command still work? (cargo install --git https://github.com/sigma0-xyz/zkbitcoin.git) or do we need to mention the binary now?

The command instructions in DEVELOPER.md need to be updated also

@ppoliani
Copy link
Contributor Author

cargo install

Yes I've tested it locally cargo install --path ..

Pushed the updated instructions. Let me know if I missed anything.

@mimoo mimoo merged commit 09fa6f9 into sigma0-dev:main Feb 1, 2024
1 check passed
@mimoo
Copy link
Contributor

mimoo commented Feb 1, 2024

Awesome! Thanks again :)

@ppoliani ppoliani deleted the chore/split_cli_admin branch February 1, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimoo mimoo mimoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move orchestartor/node commands in a different CLI
2 participants
@ppoliani @mimoo