Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolving issue54, exiting with Ctrl-D just after confirmation #57

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

jadijadi
Copy link
Contributor

@jadijadi jadijadi commented Oct 8, 2019

Resolving #54 , The confirmation dialogue asks "Do you really want to exit ([y]/n)? " and waits for one char, will exit with Y, y and Enter and will continue to the next line with anything else.

@sigmaSd
Copy link
Owner

sigmaSd commented Oct 9, 2019

thanks! Looks good, Ill hopefully merge it later today after testing it

@sigmaSd sigmaSd merged commit a5712ce into sigmaSd:master Oct 9, 2019
@sigmaSd
Copy link
Owner

sigmaSd commented Oct 9, 2019

good work, thanks!

@sigmaSd
Copy link
Owner

sigmaSd commented Oct 9, 2019

@jadijadi just some small tips, you should use cargo-fmt it makes the code a lot nicer, also print_input and clearing the buffer were not necessary
thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants