Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Change from country names to sign language names #104

Closed
4 of 6 tasks
AmitMY opened this issue Aug 21, 2023 · 1 comment
Closed
4 of 6 tasks

[Feature] Change from country names to sign language names #104

AmitMY opened this issue Aug 21, 2023 · 1 comment

Comments

@AmitMY
Copy link
Contributor

AmitMY commented Aug 21, 2023

Problem

The sign language selector is a language selector.
image

It turns out to be a little confusing, especially for cases like "swiss german" or "swiss french" where one has to select the same country but a different language.

Description

Proposal:

  • Use the actual sign language ISO codes. Say "American", "Israeli", "Swiss-German" etc...
    • This requires translating sign language names in 100+ languages (Google Translate)
    • For short names, a manual pass should be used to remove the "Sign Language" suffix/prefix in every language
  • Show country flag based on language code
  • Send the actual sign language code to the API

Maybe later:

  • Consider every non-natural language pair (for example, Hebrew, and American Sign Language) as such. When translating between non-natural pairs, we can introduce a spoken-language-machine-translation step in the middle

Alternatives

No response

Additional context

No response

@AmitMY
Copy link
Contributor Author

AmitMY commented Feb 1, 2024

Moved the remaining translation step to the i18n repo
sign/i18n#4

@AmitMY AmitMY closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant