Remove customizations for old sd-workspace header. #4
Conversation
| @@ -23,13 +23,6 @@ | |||
| <h1>Hot R.O.D.</h1> | |||
| <h4><em>Rides On Demand</em></h4> | |||
|
|
|||
| <br /> | |||
| <div> | |||
| Signadot Workspace: <input type="text" id="workspace" /> | |||
There was a problem hiding this comment.
I think after this is run, it needs to generate code as well to take effect.
esc -pkg frontend -o ./services/frontend/gen_assets.go -prefix ./services/frontend/web_assets ./services/frontend/web_assets
There was a problem hiding this comment.
Yeah I went ahead and uncommented that line in build.sh since it seems to be fast anyway. I also had to tweak the command, perhaps because of a new esc version?
|
I manually pushed an image and created a workspace for this: http://022q5u19bw3hu.preview.signadot.com/ |
| isDir: true, | ||
| }, | ||
| } | ||
|
|
||
| var _escDirs = map[string][]os.FileInfo{ | ||
|
|
||
| ".": { | ||
| "services/frontend/web_assets": { |
There was a problem hiding this comment.
This and the change on line 762 need to be reverted. This was why I didn't keep the esc command as-is in the build file. Not really sure why this changes even though we specify --prefix but never looked into it closely. Rest lgtm.
There was a problem hiding this comment.
It seems to work. Maybe this is just internal metadata that doesn't affect serving. Did you see any effects from this before?
These changes to the app code are no longer necessary.
These changes to the app code are no longer necessary.