Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware echo cancellation does not work on many devices #7635

Closed
4 tasks done
equaeghe opened this issue Apr 4, 2018 · 39 comments
Closed
4 tasks done

Hardware echo cancellation does not work on many devices #7635

equaeghe opened this issue Apr 4, 2018 · 39 comments

Comments

@equaeghe
Copy link

equaeghe commented Apr 4, 2018


This is a revival of issue #6241. The posts there contain valuable information that cannot concisely be copied here. To deal with this issue, a whitelist was in place initially, which worked in the sense that only known ‘good’ devices would use built-in echo cancellation. Afterwards a switch was made to a blacklist, which was however not updated, leaving many people with non-usable call functionality.

I suggest others experiencing this issue to wait with commenting until the developers have indicated what info they need. The material in issue #6241 should give them a good starting point.

Bug description

Echo cancellation does not work on multiple devices and for various Android versions.
For example, my Samsung GT-I9192 Galaxy S4 Mini Duos (serranodsxx) on Android 7.1.2 (LineageOS) is affected.

Steps to reproduce

  • call someone with Signal, using with affected device/OS (other party's device/OS seems irrelevant)
  • have conversation

Actual result: Other party hears disturbing echo
Expected result: Other party does not hear disturbing echo

Depending on the device, the results vary when using headphones or not. On my device, the echo becomes worse when using headphones, so in a situation where the echo cannot be caused by sound being captured by my microphone. (My guess is that the echo cancellation functionality actually adds the echo.) For others, the echo disappears in this situation.

Suggested potential workarounds until the root cause can be addressed are to update the blacklist, to include an ‘advanced’ option that switches hardware echo cancellation on or off, or to disable echo cancellation when using headphones. A workaround is needed to avoid chasing users to Skype or so. (I managed to convince my family to switch to Signal and then the whitelist-to-blacklist move forced us back to Skype.)

Device info

Device: Samsung GT-I9192 Galaxy S4 Mini Duos (serranodsxx)
Android version: 7.1.2
Signal version: 4.17.5

Link to debug log

Not applicable.

@2-4601 2-4601 added the bug label Apr 5, 2018
@moxie0 moxie0 removed the bug label Apr 5, 2018
@moxie0
Copy link
Contributor

moxie0 commented Apr 5, 2018

I'm happy to add devices to the blacklist, but only if we can confirm that they are a problem with stock Android.

@sluger
Copy link

sluger commented Apr 17, 2018

👍 for my Moto G5SPlus on Android 7.1.1 Signal 4.18.3

@moxie0
Copy link
Contributor

moxie0 commented Apr 19, 2018

@sluger We'll need the ro.product.model string for that.

@sluger
Copy link

sluger commented Apr 19, 2018

hi @moxie0, the ro.product.model is Moto G (5S) Plus

@ADepic
Copy link

ADepic commented May 20, 2018

This effects Oneplus 2 running lineage os too.

This is a deal breaker and needs to be sorted out

@schubtob
Copy link

@moxie0 Please add the Moto G4 (running stock) to the blacklist as well. I've had several people complain that they hear an echo during signal calls. Using headphones fixes this problem.

The ro.product.model string is "Moto G4".
Thanks!

@breversa
Copy link

breversa commented Jun 3, 2018

Echo happens too on the Samsung Galaxy S III : ro.product.model=GT-I9300

@2-4601
Copy link
Contributor

2-4601 commented Jun 5, 2018

@breversa Which ROM are you running on that Samsung Galaxy S III?

@breversa
Copy link

breversa commented Jun 5, 2018

The ROM is LineageOS for MicroG, taken from here : https://lineage.microg.org/

ROM download link :
https://download.lineage.microg.org/i9300/lineage-14.1-20180517-microG-i9300.zip

@ADepic
Copy link

ADepic commented Jun 5, 2018 via email

@2-4601
Copy link
Contributor

2-4601 commented Jun 5, 2018

You should confirm that it's also an issue with stock Android, otherwise it won't be blacklisted as said in #7635 (comment).

@abooij
Copy link

abooij commented Jun 5, 2018

I think there are many people not running stock Android. Personally, I'm not willing to delete my entire Android installation merely because one app is not functioning as desired. In #6241, there was a proposal to add a setting to the configuration screen. Is this something that can be considered as a remedy for such situations?

@breversa
Copy link

breversa commented Jun 7, 2018

I agree with @abooij : I'd love to confirm the bug, but I have no practical way to do it, as I'm no longer running stock on any device.
Is there any other was to test that ?

@equaeghe
Copy link
Author

equaeghe commented Jun 7, 2018

@breversa @abooij I have asked on an xda forum for my device whether someone with stock could test it. So far without response. But that is one thing you can try. Adding a setting would be ideal for me as well, but I understand that this goes against the design ideas of the developers (setting explosion).

@breversa
Copy link

breversa commented Jun 7, 2018

What about a "testing" build, then, to allow volunteers like us to test the behaviour with and without AEC, report here, then blacklist or not in the "consumer" build ?

greyson-signal pushed a commit that referenced this issue Jun 20, 2018
- Moto G4
- Nokia 5 (TA-1053)

Alleviates #7635
greyson-signal pushed a commit that referenced this issue Jun 22, 2018
- Moto G4
- Nokia 5 (TA-1053)

Alleviates #7635
@b0m0x
Copy link

b0m0x commented Jun 26, 2018

The Xiaomi Mi A1 is also affected by non-working echo cancellation on stock.
ro.product.model=Mi A1

b0m0x pushed a commit to b0m0x/Signal-Android that referenced this issue Jun 29, 2018
greyson-signal pushed a commit that referenced this issue Jul 3, 2018
@letkan
Copy link

letkan commented May 8, 2019

Please add Mi A2 Lite to the blacklist, I just tested the echo issue by replacing ro.product.model with Mi A1 and there was no more echo, finally I can use Signal for calls on this phone.

@3RMD
Copy link

3RMD commented Nov 10, 2019

Same thing with Xiaomi Mi A2. Tested on stock rom and various custom roms (conversation partner using iPhone).
Please add to blacklist.
Thanks in advance.

@JoaquimCSantos
Copy link

Xiaomi Mi A2 echo cancellation was resolved in the previous version. But with this last update it came back. Please add again to blacklist.
Thanks!

@ghost
Copy link

ghost commented Mar 18, 2020

@greyson-signal Please also add ro.product.model = "Moto G4 Plus" to the HARDWARE_AEC_BLACKLIST. The "Moto G4" is on the list but the Moto G4 Plus is also affected with echos. Thank you!

@szabolcs-cs
Copy link

I have this problem with the Galaxy S4 (I9505) on Lineage OS. Could we get an option in Settings to switch to software echo cancellation manually?

@zjapske
Copy link

zjapske commented Apr 14, 2020

I have an galaxy s6 sm-920f, I tried multiple lineage os versions (14.1 16.0 and 17.1) all persons on the other side complained about hearing their own voice back with a small delay. I flashed my phone back to the stock rom call the echo is gone.

@Genis-Sage
Copy link

When I'm talking to my mom, I also hear my voice as an echo

my mother's phone: BQ Aquaris U Lite, stock android 7

@Salokyn
Copy link

Salokyn commented Sep 7, 2020

Hi,

I get an echo (I ear my own voice) on a Oneplus 5 (ONEPLUS A5010, Oxygen OS 9.0.10) when calling a Oneplus 3 (ONEPLUS A3003, Oxygen OS 9.0.6).

It's fine on both sides when Oneplus 3 calls Oneplus 5.

@Lusofreak
Copy link

LG G7 THINQ ...

It's not a device issue if many devices are affected... it's a software issue, better coding/solution required...

@billie80
Copy link

Is it possible to add another device to the HARDWARE_AEC_BLACKLIST?
ro.product.model = SHIFT6mq

It is the newest device from a German manufacturer. They currently have problems with Hardware AEC. It would be great if it could be added to the list. Thank you very much in advance!

@Caerbannog
Copy link
Contributor

[...] not all problem devices will be confirmed. [...]
With so many Android phones out there, having an advanced setting to turn off hardware echo cancellation and adding an FAQ entry [...]

Another solution could be to help inexperienced users to diagnose such issues and submit them.
Most VOIP solutions show a screen at random after calls for this purpose.

Something like a question "How was your call", with a thumb-up and a thumb-down buttons.
When the thumb-down is clicked, other questions can appear:

What was the problem?

  • my correspondent heard an echo
  • other

Click here to submit a report with your phone model

@jemaltz
Copy link

jemaltz commented Mar 1, 2022

I believe that I am experiencing this issue with my Samsung s10e
ro.product.model: SM-G970F

The issue occurs when I am on speakerphone, and is generally triggered if an object/finger comes in close proximity to the noise cancelling microphone hole on the top of the phone

The issue remains until I switch speakerphone off

Thanks!

@JP2-S
Copy link

JP2-S commented Jul 30, 2022

Echo from Samsung tab s5e SM-T720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests