-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardware echo cancellation does not work on many devices #7635
Comments
I'm happy to add devices to the blacklist, but only if we can confirm that they are a problem with stock Android. |
👍 for my Moto G5SPlus on Android 7.1.1 Signal 4.18.3 |
@sluger We'll need the ro.product.model string for that. |
hi @moxie0, the ro.product.model is |
This effects Oneplus 2 running lineage os too. This is a deal breaker and needs to be sorted out |
@moxie0 Please add the Moto G4 (running stock) to the blacklist as well. I've had several people complain that they hear an echo during signal calls. Using headphones fixes this problem. The ro.product.model string is "Moto G4". |
Echo happens too on the Samsung Galaxy S III : |
@breversa Which ROM are you running on that Samsung Galaxy S III? |
The ROM is LineageOS for MicroG, taken from here : https://lineage.microg.org/ ROM download link : |
I'm running that too - but I've had this problem since lineage plain version 14.1
|
You should confirm that it's also an issue with stock Android, otherwise it won't be blacklisted as said in #7635 (comment). |
I think there are many people not running stock Android. Personally, I'm not willing to delete my entire Android installation merely because one app is not functioning as desired. In #6241, there was a proposal to add a setting to the configuration screen. Is this something that can be considered as a remedy for such situations? |
I agree with @abooij : I'd love to confirm the bug, but I have no practical way to do it, as I'm no longer running stock on any device. |
@breversa @abooij I have asked on an xda forum for my device whether someone with stock could test it. So far without response. But that is one thing you can try. Adding a setting would be ideal for me as well, but I understand that this goes against the design ideas of the developers (setting explosion). |
What about a "testing" build, then, to allow volunteers like us to test the behaviour with and without AEC, report here, then blacklist or not in the "consumer" build ? |
- Moto G4 - Nokia 5 (TA-1053) Alleviates #7635
- Moto G4 - Nokia 5 (TA-1053) Alleviates #7635
The Xiaomi Mi A1 is also affected by non-working echo cancellation on stock. |
Please add |
Same thing with Xiaomi Mi A2. Tested on stock rom and various custom roms (conversation partner using iPhone). |
Xiaomi Mi A2 echo cancellation was resolved in the previous version. But with this last update it came back. Please add again to blacklist. |
@greyson-signal Please also add ro.product.model = "Moto G4 Plus" to the HARDWARE_AEC_BLACKLIST. The "Moto G4" is on the list but the Moto G4 Plus is also affected with echos. Thank you! |
I have this problem with the Galaxy S4 (I9505) on Lineage OS. Could we get an option in Settings to switch to software echo cancellation manually? |
I have an galaxy s6 sm-920f, I tried multiple lineage os versions (14.1 16.0 and 17.1) all persons on the other side complained about hearing their own voice back with a small delay. I flashed my phone back to the stock rom call the echo is gone. |
When I'm talking to my mom, I also hear my voice as an echo my mother's phone: BQ Aquaris U Lite, stock android 7 |
Hi, I get an echo (I ear my own voice) on a Oneplus 5 (ONEPLUS A5010, Oxygen OS 9.0.10) when calling a Oneplus 3 (ONEPLUS A3003, Oxygen OS 9.0.6). It's fine on both sides when Oneplus 3 calls Oneplus 5. |
LG G7 THINQ ... It's not a device issue if many devices are affected... it's a software issue, better coding/solution required... |
Is it possible to add another device to the HARDWARE_AEC_BLACKLIST? It is the newest device from a German manufacturer. They currently have problems with Hardware AEC. It would be great if it could be added to the list. Thank you very much in advance! |
Another solution could be to help inexperienced users to diagnose such issues and submit them. Something like a question "How was your call", with a thumb-up and a thumb-down buttons.
|
I believe that I am experiencing this issue with my Samsung s10e The issue occurs when I am on speakerphone, and is generally triggered if an object/finger comes in close proximity to the noise cancelling microphone hole on the top of the phone The issue remains until I switch speakerphone off Thanks! |
Echo from Samsung tab s5e SM-T720 |
This is a revival of issue #6241. The posts there contain valuable information that cannot concisely be copied here. To deal with this issue, a whitelist was in place initially, which worked in the sense that only known ‘good’ devices would use built-in echo cancellation. Afterwards a switch was made to a blacklist, which was however not updated, leaving many people with non-usable call functionality.
I suggest others experiencing this issue to wait with commenting until the developers have indicated what info they need. The material in issue #6241 should give them a good starting point.
Bug description
Echo cancellation does not work on multiple devices and for various Android versions.
For example, my Samsung GT-I9192 Galaxy S4 Mini Duos (serranodsxx) on Android 7.1.2 (LineageOS) is affected.
Steps to reproduce
Actual result: Other party hears disturbing echo
Expected result: Other party does not hear disturbing echo
Depending on the device, the results vary when using headphones or not. On my device, the echo becomes worse when using headphones, so in a situation where the echo cannot be caused by sound being captured by my microphone. (My guess is that the echo cancellation functionality actually adds the echo.) For others, the echo disappears in this situation.
Suggested potential workarounds until the root cause can be addressed are to update the blacklist, to include an ‘advanced’ option that switches hardware echo cancellation on or off, or to disable echo cancellation when using headphones. A workaround is needed to avoid chasing users to Skype or so. (I managed to convince my family to switch to Signal and then the whitelist-to-blacklist move forced us back to Skype.)
Device info
Device: Samsung GT-I9192 Galaxy S4 Mini Duos (serranodsxx)
Android version: 7.1.2
Signal version: 4.17.5
Link to debug log
Not applicable.
The text was updated successfully, but these errors were encountered: