Periodically wake the WebSocket, when GCM is disabled #7666
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the WebSocketAlarm, to periodically wake the WebSocket and with it, any threads that may be stuck in blocking wait, while the device is sleeping. Fixes signalapp#6644 // FREEBIE
|
I left comments in the libsignal PR, this was not what I laid out that needs to be done. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the WebSocketAlarm, to periodically wake the WebSocket and with
it, any threads that may be stuck in blocking wait, while the device
is sleeping.
Fixes #6644
// FREEBIE
Contributor checklist
Fixes #1234syntaxDescription
This is a reimplementation of #7100. Please see signalapp/libsignal-service-java#51 for more details.