Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify border color of quote when quoted file is not found #6454

Closed
wants to merge 1 commit into from

Conversation

hackerbirds
Copy link
Contributor

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A yarn ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

There sometimes is a visual problem where the quote border becomes black on the "Original file not found part", like so:
beforenotfound2

I can't 100% fully reproduce which is odd, but it does happen sometimes (moreso with light theme?) so I added CSS to explicitly specify the border color on the appropriate element and make sure it can't happen anymore:
afternotfound2

Note that both light theme and dark these use #FFFFFF for this border so I didn't feel the need to consider the individual cases

@scottnonnenberg-signal
Copy link
Contributor

We've already got a fix for this coming in the next release - thanks for jumping in, though!

@hackerbirds hackerbirds deleted the quote-border-fix branch June 1, 2023 21:16
@hackerbirds hackerbirds restored the quote-border-fix branch June 1, 2023 21:16
@hackerbirds hackerbirds deleted the quote-border-fix branch June 1, 2023 21:16
@hackerbirds hackerbirds restored the quote-border-fix branch June 1, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants