Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domain that does not exist from pre-generation list, thus fixing build. #6898

Closed
wants to merge 1 commit into from

Conversation

g1a55er
Copy link

@g1a55er g1a55er commented Jun 1, 2024

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A yarn ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

Hi! I hope this isn't noise.

I was trying to build the project to test my other contribution. I could not do so successfully. My build kept failing with this error:

Error: getaddrinfo ENOTFOUND create.signal.art
    at GetAddrInfoReqWrap.onlookupall [as oncomplete] (node:dns:118:26) {
  errno: -3008,
  code: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: 'create.signal.art'
}

When I check for the existence of this domain via dig create.signal.art A +short, I get that no record exists. I also do not see it checking on an external tool (e.g. mxtoolbox.com), so I don't think it's a problem with my machine configuration.

To resolve this, I just removed the "create.signal.art" domain from the generate-dns-fallback.ts file. I see that @indutny-signal created this just a few weeks ago, so hopefully this is the right thing to do.

Test Strategy

All tests passed when I ran yarn ready. I also was able to launch the app and send a message to myself using yarn start.

@g1a55er g1a55er changed the title Remove domain that does not exist Remove domain that does not exist from pre-generation list, thus fixing build. Jun 1, 2024
@jamiebuilds-signal
Copy link
Member

Oh sorry about this, it's been fixed internally and will be released in the next beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants