Remove domain that does not exist from pre-generation list, thus fixing build. #6898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
main
branchyarn ready
run passes successfully (more about tests here)Description
Hi! I hope this isn't noise.
I was trying to build the project to test my other contribution. I could not do so successfully. My build kept failing with this error:
When I check for the existence of this domain via
dig create.signal.art A +short
, I get that no record exists. I also do not see it checking on an external tool (e.g. mxtoolbox.com), so I don't think it's a problem with my machine configuration.To resolve this, I just removed the "create.signal.art" domain from the generate-dns-fallback.ts file. I see that @indutny-signal created this just a few weeks ago, so hopefully this is the right thing to do.
Test Strategy
All tests passed when I ran
yarn ready
. I also was able to launch the app and send a message to myself usingyarn start
.