pdbcycle: removed extra iteration of read locations #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summary: when we read locations during Read() call, we had two loops. One was incrementing stats information and other was updating return value. Both the iterations was on same data slice. If we look at system as a whole there are multiple go-routines calling this Read api for multiple datum's. Having one iteration should speed some cpu time by a small factor. test: ran all unit test cases
mdubbyap
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary: when we read locations during Read() call, we had two loops.
One was incrementing stats information and other was updating return
value. Both the iterations was on same data slice. If we look at system
as a whole there are multiple go-routines calling this Read api for
multiple datum's. Having one iteration should speed some cpu time by a
small factor.
test: ran all unit test cases