Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing thrift to use 0.11.0 version plus hot_fixes #114

Merged
merged 1 commit into from
Dec 11, 2018
Merged

fixing thrift to use 0.11.0 version plus hot_fixes #114

merged 1 commit into from
Dec 11, 2018

Conversation

jgheewala
Copy link
Contributor

No description provided.

@jgheewala
Copy link
Contributor Author

once this is merged i will update sfxinternalgo to use 0.11.0 thrift + hot fixes from (@mdubbyap & @jgheewala )

mdubbyap
mdubbyap approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@mdubbyap mdubbyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you git tag this release when you land please, it's a breaking change. Also please update with exactly what version of thrift branch/hash you need for this to work optimally.

@jgheewala jgheewala merged commit b9df49f into master Dec 11, 2018
@atoulme atoulme deleted the thrift_fix branch January 5, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdubbyap mdubbyap mdubbyap approved these changes

@tedoc2000 tedoc2000 Awaiting requested review from tedoc2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgheewala @mdubbyap