Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preprocess yaml templates with Jinja (Fixes #6) #8

Merged
merged 7 commits into from
Feb 18, 2014
Merged

Preprocess yaml templates with Jinja (Fixes #6) #8

merged 7 commits into from
Feb 18, 2014

Conversation

Jud
Copy link
Contributor

@Jud Jud commented Feb 14, 2014

No description provided.

@mpetazzoni
Copy link
Contributor

Hey,

Thanks for doing this! See my comments.

@Jud
Copy link
Contributor Author

Jud commented Feb 18, 2014

@mpetazzoni The AttrDict was an attempt to mock the ArgumentParser options object for testing, but I think the latest commits are a bit more clean.

Also fixed some things that were causing the python 3.3 tests to fail.

mpetazzoni added a commit that referenced this pull request Feb 18, 2014
@mpetazzoni
Merge pull request #8 from nybex/preprocess-yaml-with-jinja
535e1bd 
Preprocess yaml templates with Jinja (Fixes #6)
@mpetazzoni mpetazzoni merged commit 535e1bd into signalfx:master Feb 18, 2014
@mpetazzoni
Copy link
Contributor

Thanks!

@Jud Jud deleted the preprocess-yaml-with-jinja branch February 18, 2014 14:29
@Jud Jud mentioned this pull request Feb 27, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jud @mpetazzoni