smartagent extension: ensure propagation of collectd bundle dir #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 88.62% 88.62%
=======================================
Files 16 16
Lines 958 958
=======================================
Hits 849 849
Misses 76 76
Partials 33 33
Continue to review full report at Codecov.
|
asuresh4
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix a bug in the SA Extension that leaves* the default collectd config partially populated and doesn't* respect the desired executable location, which is what the agent actually uses.
I've corrected the relevant unit test with the desired value. The integration tests missed this since they set a temporary collectd configDir option, which I'm not able to bypass at this time due to resulting permission errors w/ the default.