Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartagent extension: ensure propagation of collectd bundle dir #180

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

rmfitzpatrick
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick commented Mar 18, 2021

These changes fix a bug in the SA Extension that leaves* the default collectd config partially populated and doesn't* respect the desired executable location, which is what the agent actually uses.

I've corrected the relevant unit test with the desired value. The integration tests missed this since they set a temporary collectd configDir option, which I'm not able to bypass at this time due to resulting permission errors w/ the default.

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #180 (a0c7c70) into main (89c8812) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   88.62%   88.62%           
=======================================
  Files          16       16           
  Lines         958      958           
=======================================
  Hits          849      849           
  Misses         76       76           
  Partials       33       33           
Impacted Files Coverage Δ
internal/extension/smartagentextension/config.go 89.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c8812...a0c7c70. Read the comment docs.

@rmfitzpatrick rmfitzpatrick merged commit e3a4946 into main Mar 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the sa_extension_set_sub_bundle_dir branch March 18, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants