Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpsinkexporter: add support for metrics and filtering #2959

Merged
merged 1 commit into from
Apr 26, 2023
Merged

httpsinkexporter: add support for metrics and filtering #2959

merged 1 commit into from
Apr 26, 2023

Conversation

owais
Copy link
Contributor

@owais owais commented Apr 14, 2023

  • now supports metrics datatype.
  • also supports filtering by name and attributes (metrics only)
  • query URL has changed from / to /spans and /metrics
  • fixed some other subtle bugs/issues

@owais owais force-pushed the httpsink-support-metrics branch 4 times, most recently from 6639cc4 to cbb8cc4 Compare April 14, 2023 06:45
@owais owais marked this pull request as ready for review April 14, 2023 07:29
@owais owais requested review from a team as code owners April 14, 2023 07:29
@owais owais force-pushed the httpsink-support-metrics branch 4 times, most recently from 4692c15 to a7e9a51 Compare April 15, 2023 05:12
@owais
Copy link
Contributor Author

owais commented Apr 18, 2023

Thanks for the review @atoulme. PTAL

atoulme
atoulme approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, I have reached out to the team for a second look however.

@owais owais force-pushed the httpsink-support-metrics branch 10 times, most recently from 207c585 to c1eae26 Compare April 24, 2023 15:33
@rmfitzpatrick
Copy link
Contributor

Pulling in main should fix integration test issues

@owais
httpsinkexporter: add support for metrics and filtering
b54db13 
- now supports metrics datatype.
- also supports filtering by name and attributes (metrics only)
- query URL has changed from `/` to `/spans` and `/metrics`
- fixed a number of other subtle bugs/issues
@owais
Copy link
Contributor Author

owais commented Apr 26, 2023

Thanks @rmfitzpatrick. All passing now.

@rmfitzpatrick rmfitzpatrick merged commit cdd6973 into signalfx:main Apr 26, 2023
@owais owais deleted the httpsink-support-metrics branch April 28, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

@atoulme atoulme atoulme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owais @rmfitzpatrick @atoulme