Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/forward] Add forward connector support #3100

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

jinja2
Copy link
Contributor

@jinja2 jinja2 commented May 9, 2023

Adds support for the upstream forward connector

@jinja2 jinja2 requested review from a team as code owners May 9, 2023 16:36
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Were you able to run any basic demo locally to make sure the connector works in our distro?

@dmitryax
Copy link
Contributor

dmitryax commented May 9, 2023

Can you please also add a new section to https://github.com/signalfx/splunk-otel-collector/blob/main/docs/components.md ?

@jinja2
Copy link
Contributor Author

jinja2 commented May 9, 2023

Looks good! Were you able to run any basic demo locally to make sure the connector works in our distro?

@crobert-1 yes, got a test build running in lab

Can you please also add a new section to https://github.com/signalfx/splunk-otel-collector/blob/main/docs/components.md ?

@dmitryax I have a new table in docs/components.go or are you referring to something else?

@dmitryax
Copy link
Contributor

dmitryax commented May 9, 2023

@dmitryax I have a new table in docs/components.go or are you referring to something else?

I see it now. Sorry, I must have missed it.

Can you please rebase to make sure the PR contains only your changes?

@jinja2 jinja2 merged commit 9b8e280 into main May 9, 2023
@jinja2 jinja2 deleted the add-connector-forward branch May 9, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants