Prevent setting SA monitor configs with invalid endpoint fields #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
sareceiverendpointbugfix
branch
from
5237bcf
to
7f7d5f9
Compare
jvoravong
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
acceptsEndpointsvalue is used to determine ifendpoint-derived host and port values should be used in monitor configs. This logic is invalid where endpoints are accepted buthostandportdon't exist or are of unexpected string values. These changes ensure the field exists before attempting to set them, and also tries port strings since changing the config field type could be a breaking one.Resolves #2264.