Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distro: Add WithIDGenerator option #2634

Merged
merged 6 commits into from
Nov 14, 2023
Merged

distro: Add WithIDGenerator option #2634

merged 6 commits into from
Nov 14, 2023

Conversation

sergiopastan
Copy link
Contributor

This adds the WithIDGenerator option mentioned in this issue: #1377

@sergiopastan sergiopastan requested review from a team as code owners November 13, 2023 03:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sergiopastan
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Nov 13, 2023
@srv-gh-o11y-gdi-cla
@sergiopastan has signed the CLA in signalfx/splunk-otel-go#2634
a426ee8
pellared
pellared reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@pellared pellared left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the CHANGELOG.md and fix issues reported by golangci-lint?

distro/config.go Outdated Show resolved Hide resolved
distro/otel_test.go Outdated Show resolved Hide resolved
@sergiopastan sergiopastan requested a review from a team as a code owner November 14, 2023 15:36
@sergiopastan
Copy link
Contributor Author

Thank you for your comments @pellared . I already added your suggestions and the changelog

@pellared pellared changed the title Add WithIDGenerator option distro: Add WithIDGenerator option Nov 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ef9bcf) 78.43% compared to head (0b6ff48) 82.77%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2634      +/-   ##
==========================================
+ Coverage   78.43%   82.77%   +4.33%     
==========================================
  Files          83       83              
  Lines        3223     3228       +5     
==========================================
+ Hits         2528     2672     +144     
+ Misses        617      483     -134     
+ Partials       78       73       -5
Flag Coverage Δ
Linux 82.46% <100.00%> (?)
Windows 78.74% <100.00%> (+0.03%) ⬆️
macOS 78.15% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiopastan
Copy link
Contributor Author

do I have to create a signed commit?

@pellared
Copy link
Contributor

do I have to create a signed commit?

Yes. This may help you: https://superuser.com/questions/397149/can-you-gpg-sign-old-commits

MrAlias
MrAlias approved these changes Nov 14, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@pellared
Copy link
Contributor

@sergiopastan We are just waiting for you to sign the commits.

sergiopastan and others added 5 commits November 14, 2023 12:39
@sergiopastan
Add WithIDGenerator option
ef88f6d
@sergiopastan
Reorder testIDGenerator type
aa082ba
@sergiopastan
Add changelog and resolve comments
10682af
@dependabot @sergiopastan
Bump github.com/goyek/x from 0.1.5 to 0.1.6 in /build (signalfx#2636)
6af72dc 
Bumps [github.com/goyek/x](https://github.com/goyek/x) from 0.1.5 to 0.1.6.
- [Release notes](https://github.com/goyek/x/releases)
- [Changelog](https://github.com/goyek/x/blob/main/CHANGELOG.md)
- [Commits](goyek/x@v0.1.5...v0.1.6)

---
updated-dependencies:
- dependency-name: github.com/goyek/x
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@renovate @pellared @sergiopastan
Update k8s.io/kube-openapi digest to 778a556 (signalfx#2635)
14f9bdf 
* Update k8s.io/kube-openapi digest to 778a556

* go mod tidy

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@sergiopastan
Copy link
Contributor Author

sergiopastan commented Nov 14, 2023 •
edited
Loading

Hi @pellared I think is ok right now. Let me know if anything else is needed. Thanks!

@pellared
Copy link
Contributor

@sergiopastan All good. Thanks for your contribution 🎉 I will merge once the CI passes.

@pellared pellared merged commit 88d29e9 into signalfx:main Nov 14, 2023
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
@sergiopastan sergiopastan deleted the ig-generator branch November 14, 2023 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergiopastan @codecov-commenter @pellared @MrAlias