Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Custom ID Generator #1377

Closed
sergiopastan opened this issue Sep 30, 2022 · 2 comments
Closed

[Feature Request] Custom ID Generator #1377

sergiopastan opened this issue Sep 30, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@sergiopastan
Copy link
Contributor

I wonder if there is a way to set a custom IDGenerator for SpanID and TraceID. According to this document: https://docs.splunk.com/Observability/gdi/get-data-in/application/go/troubleshooting/migrate-signalfx-go-to-otel.html#replace-startspanoption-instances

Span IDs are automatically set. If you require custom span IDs, create a custom IDGenerator.

But I can 't figure out how to do ir currently using distro.Run(...) Options.

In order to do it now I have to create a new TracerProvider with all the TracerProviderOptions in distro/otel.go Run function.

I think it would be useful to have an Option to add a custom IDGenerator to the initial instrumentation.

Thanks

@sergiopastan sergiopastan added the bug Something isn't working label Sep 30, 2022
@sergiopastan
Copy link
Contributor Author

Sorry for tagging this as a bug. I think enhancement label would fit better

@pellared pellared added enhancement New feature or request and removed bug Something isn't working labels Nov 3, 2022
@sergiopastan
Copy link
Contributor Author

closing this issue because it was added in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants