fix: Remove maximum queue size from BatchSpanProcessor #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falling back to default value of 2048
mhennoch
approved these changes
Jul 9, 2021
jtmalinowski
approved these changes
Jul 9, 2021
sfishel-splunk
pushed a commit
to sfishel-splunk/splunk-otel-js-web
that referenced
this pull request
Jun 22, 2022
falling back to default value of 2048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently (at default values) if there's more than 40 spans within the 5s batching interval then all of the new ones are dropped, which is pretty low and internal usage hit this limit with ease.
Removing this value, which causes it to use the default value of 2048. For really spammy span generators the exporter's 100 per 30s per component limit still applies.