Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event listeners throwing when useCapture = null #374

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

t2t2
Copy link
Contributor

@t2t2 t2t2 commented Jun 1, 2022

Description

Causes error to throw when using react-onclickoutside:

https://github.com/Pomax/react-onclickoutside/blob/15c3cdaed0d8314ac68bc53c7fad7b2c2f3c4ae2/src/index.js#L19

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Added unit tests

@t2t2 t2t2 requested review from a team as code owners June 1, 2022 11:53
@t2t2 t2t2 temporarily deployed to integration June 1, 2022 11:53 Inactive
@t2t2 t2t2 temporarily deployed to integration June 1, 2022 12:02 Inactive
@t2t2 t2t2 merged commit 93611ec into main Jun 1, 2022
@t2t2 t2t2 deleted the event-listener-capture-null branch June 1, 2022 12:34
sfishel-splunk pushed a commit to sfishel-splunk/splunk-otel-js-web that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants