Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra check for IE compatibility in xhr instrumentation #380

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

t2t2
Copy link
Contributor

@t2t2 t2t2 commented Jun 6, 2022

Description

In @opentelemetry/instrumentation-xml-http-request 0.28.0, following source:

    if (
      !xhrMem ||
      typeof PerformanceObserver !== 'function' ||
      typeof PerformanceResourceTiming !== 'function'
    ) {

has been for some reason compiled into

        if (!xhrMem ||
            PerformanceObserver == null ||
            PerformanceResourceTiming == null) {
            return;
        }

Which causes "PerformanceObserver is undefined" error in IE and breaks xhr calls. This seems to be fixed in 0.29.0 but as contrib doesn't have compatible packages adding a hotfix

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Manual testing

@t2t2 t2t2 requested review from a team as code owners June 6, 2022 08:27
@t2t2 t2t2 temporarily deployed to integration June 6, 2022 08:48 Inactive
@t2t2 t2t2 merged commit 7154700 into main Jun 6, 2022
@t2t2 t2t2 deleted the xhr-ie-protection branch June 6, 2022 12:40
sfishel-splunk pushed a commit to sfishel-splunk/splunk-otel-js-web that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants