Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix folders being ignored while packing #726

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Fix folders being ignored while packing #726

merged 1 commit into from
Dec 11, 2023

Conversation

t2t2
Copy link
Contributor

@t2t2 t2t2 commented Dec 11, 2023

Description

#719 added instrumentation code in folders but missed out on folders not being included in the npm pack

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Delete options that are not relevant.

  • Manual testing
npm pack output w/ change 
% npm pack -w packages/web 
npm notice 
npm notice 📦  @splunk/otel-web@0.17.0-beta.0
npm notice === Tarball Contents === 
npm notice 11.4kB LICENSE                                                       
npm notice 2.8kB  README.md                                                     
npm notice 1.3kB  dist/cjs/EventTarget.d.ts                                     
npm notice 1.7kB  dist/cjs/EventTarget.js                                       
npm notice 1.0kB  dist/cjs/EventTarget.js.map                                   
npm notice 6.9kB  dist/cjs/index.d.ts                                           
npm notice 17.1kB dist/cjs/index.js                                             
npm notice 9.3kB  dist/cjs/index.js.map                                         
npm notice 180B   dist/cjs/indexBrowser.d.ts                                    
npm notice 742B   dist/cjs/indexBrowser.js                                      
npm notice 177B   dist/cjs/indexBrowser.js.map                                  
npm notice 0B     dist/cjs/polyfill-safari10.d.ts                               
npm notice 1.3kB  dist/cjs/polyfill-safari10.js                                 
npm notice 520B   dist/cjs/polyfill-safari10.js.map                             
npm notice 313B   dist/cjs/servertiming.d.ts                                    
npm notice 2.1kB  dist/cjs/servertiming.js                                      
npm notice 1.2kB  dist/cjs/servertiming.js.map                                  
npm notice 421B   dist/cjs/session.d.ts                                         
npm notice 5.9kB  dist/cjs/session.js                                           
npm notice 3.6kB  dist/cjs/session.js.map                                       
npm notice 1.1kB  dist/cjs/SessionBasedSampler.d.ts                             
npm notice 2.6kB  dist/cjs/SessionBasedSampler.js                               
npm notice 1.9kB  dist/cjs/SessionBasedSampler.js.map                           
npm notice 397B   dist/cjs/SplunkConnectivityInstrumentation.d.ts               
npm notice 2.2kB  dist/cjs/SplunkConnectivityInstrumentation.js                 
npm notice 1.4kB  dist/cjs/SplunkConnectivityInstrumentation.js.map             
npm notice 3.4kB  dist/cjs/SplunkContextManager.d.ts                            
npm notice 21.5kB dist/cjs/SplunkContextManager.js                              
npm notice 15.3kB dist/cjs/SplunkContextManager.js.map                          
npm notice 445B   dist/cjs/SplunkDocumentLoadInstrumentation.d.ts               
npm notice 3.7kB  dist/cjs/SplunkDocumentLoadInstrumentation.js                 
npm notice 2.0kB  dist/cjs/SplunkDocumentLoadInstrumentation.js.map             
npm notice 932B   dist/cjs/SplunkErrorInstrumentation.d.ts                      
npm notice 6.4kB  dist/cjs/SplunkErrorInstrumentation.js                        
npm notice 5.5kB  dist/cjs/SplunkErrorInstrumentation.js.map                    
npm notice 2.0kB  dist/cjs/SplunkExporter.d.ts                                  
npm notice 6.1kB  dist/cjs/SplunkExporter.js                                    
npm notice 4.6kB  dist/cjs/SplunkExporter.js.map                                
npm notice 260B   dist/cjs/SplunkFetchInstrumentation.d.ts                      
npm notice 2.0kB  dist/cjs/SplunkFetchInstrumentation.js                        
npm notice 987B   dist/cjs/SplunkFetchInstrumentation.js.map                    
npm notice 374B   dist/cjs/SplunkLongTaskInstrumentation.d.ts                   
npm notice 3.5kB  dist/cjs/SplunkLongTaskInstrumentation.js                     
npm notice 2.5kB  dist/cjs/SplunkLongTaskInstrumentation.js.map                 
npm notice 393B   dist/cjs/SplunkPageVisibilityInstrumentation.d.ts             
npm notice 2.2kB  dist/cjs/SplunkPageVisibilityInstrumentation.js               
npm notice 1.4kB  dist/cjs/SplunkPageVisibilityInstrumentation.js.map           
npm notice 798B   dist/cjs/SplunkPostDocLoadResourceInstrumentation.d.ts        
npm notice 5.2kB  dist/cjs/SplunkPostDocLoadResourceInstrumentation.js          
npm notice 3.4kB  dist/cjs/SplunkPostDocLoadResourceInstrumentation.js.map      
npm notice 1.7kB  dist/cjs/SplunkSocketIoClientInstrumentation.d.ts             
npm notice 8.4kB  dist/cjs/SplunkSocketIoClientInstrumentation.js               
npm notice 5.6kB  dist/cjs/SplunkSocketIoClientInstrumentation.js.map           
npm notice 494B   dist/cjs/SplunkSpanAttributesProcessor.d.ts                   
npm notice 1.7kB  dist/cjs/SplunkSpanAttributesProcessor.js                     
npm notice 923B   dist/cjs/SplunkSpanAttributesProcessor.js.map                 
npm notice 1.1kB  dist/cjs/SplunkUserInteractionInstrumentation.d.ts            
npm notice 5.5kB  dist/cjs/SplunkUserInteractionInstrumentation.js              
npm notice 3.8kB  dist/cjs/SplunkUserInteractionInstrumentation.js.map          
npm notice 716B   dist/cjs/SplunkWebSocketInstrumentation.d.ts                  
npm notice 9.4kB  dist/cjs/SplunkWebSocketInstrumentation.js                    
npm notice 6.6kB  dist/cjs/SplunkWebSocketInstrumentation.js.map                
npm notice 201B   dist/cjs/SplunkWebTracerProvider.d.ts                         
npm notice 1.4kB  dist/cjs/SplunkWebTracerProvider.js                           
npm notice 533B   dist/cjs/SplunkWebTracerProvider.js.map                       
npm notice 276B   dist/cjs/SplunkXhrPlugin.d.ts                                 
npm notice 2.9kB  dist/cjs/SplunkXhrPlugin.js                                   
npm notice 1.4kB  dist/cjs/SplunkXhrPlugin.js.map                               
npm notice 230B   dist/cjs/synthetics.d.ts                                      
npm notice 920B   dist/cjs/synthetics.js                                        
npm notice 246B   dist/cjs/synthetics.js.map                                    
npm notice 170B   dist/cjs/upstream/user-interaction/enums/AttributeNames.d.ts  
npm notice 1.1kB  dist/cjs/upstream/user-interaction/enums/AttributeNames.js    
npm notice 342B   dist/cjs/upstream/user-interaction/enums/AttributeNames.js.map
npm notice 3.0kB  dist/cjs/upstream/user-interaction/instrumentation.d.ts       
npm notice 13.4kB dist/cjs/upstream/user-interaction/instrumentation.js         
npm notice 8.8kB  dist/cjs/upstream/user-interaction/instrumentation.js.map     
npm notice 193B   dist/cjs/upstream/user-interaction/internal-types.d.ts        
npm notice 845B   dist/cjs/upstream/user-interaction/internal-types.js          
npm notice 195B   dist/cjs/upstream/user-interaction/internal-types.js.map      
npm notice 826B   dist/cjs/upstream/user-interaction/types.d.ts                 
npm notice 751B   dist/cjs/upstream/user-interaction/types.js                   
npm notice 173B   dist/cjs/upstream/user-interaction/types.js.map               
npm notice 41B    dist/cjs/upstream/user-interaction/version.d.ts               
npm notice 868B   dist/cjs/upstream/user-interaction/version.js                 
npm notice 222B   dist/cjs/upstream/user-interaction/version.js.map             
npm notice 2.1kB  dist/cjs/utils.d.ts                                           
npm notice 5.0kB  dist/cjs/utils.js                                             
npm notice 3.0kB  dist/cjs/utils.js.map                                         
npm notice 41B    dist/cjs/version.d.ts                                         
npm notice 784B   dist/cjs/version.js                                           
npm notice 177B   dist/cjs/version.js.map                                       
npm notice 124B   dist/cjs/webvitals.d.ts                                       
npm notice 1.7kB  dist/cjs/webvitals.js                                         
npm notice 1.2kB  dist/cjs/webvitals.js.map                                     
npm notice 1.3kB  dist/esm/EventTarget.d.ts                                     
npm notice 1.5kB  dist/esm/EventTarget.js                                       
npm notice 1.0kB  dist/esm/EventTarget.js.map                                   
npm notice 6.9kB  dist/esm/index.d.ts                                           
npm notice 15.2kB dist/esm/index.js                                             
npm notice 10.3kB dist/esm/index.js.map                                         
npm notice 180B   dist/esm/indexBrowser.d.ts                                    
npm notice 653B   dist/esm/indexBrowser.js                                      
npm notice 193B   dist/esm/indexBrowser.js.map                                  
npm notice 0B     dist/esm/polyfill-safari10.d.ts                               
npm notice 1.3kB  dist/esm/polyfill-safari10.js                                 
npm notice 520B   dist/esm/polyfill-safari10.js.map                             
npm notice 313B   dist/esm/servertiming.d.ts                                    
npm notice 1.8kB  dist/esm/servertiming.js                                      
npm notice 1.2kB  dist/esm/servertiming.js.map                                  
npm notice 421B   dist/esm/session.d.ts                                         
npm notice 5.6kB  dist/esm/session.js                                           
npm notice 3.6kB  dist/esm/session.js.map                                       
npm notice 1.1kB  dist/esm/SessionBasedSampler.d.ts                             
npm notice 2.5kB  dist/esm/SessionBasedSampler.js                               
npm notice 1.9kB  dist/esm/SessionBasedSampler.js.map                           
npm notice 397B   dist/esm/SplunkConnectivityInstrumentation.d.ts               
npm notice 2.0kB  dist/esm/SplunkConnectivityInstrumentation.js                 
npm notice 1.4kB  dist/esm/SplunkConnectivityInstrumentation.js.map             
npm notice 3.4kB  dist/esm/SplunkContextManager.d.ts                            
npm notice 20.6kB dist/esm/SplunkContextManager.js                              
npm notice 15.1kB dist/esm/SplunkContextManager.js.map                          
npm notice 445B   dist/esm/SplunkDocumentLoadInstrumentation.d.ts               
npm notice 3.4kB  dist/esm/SplunkDocumentLoadInstrumentation.js                 
npm notice 2.1kB  dist/esm/SplunkDocumentLoadInstrumentation.js.map             
npm notice 932B   dist/esm/SplunkErrorInstrumentation.d.ts                      
npm notice 6.0kB  dist/esm/SplunkErrorInstrumentation.js                        
npm notice 5.6kB  dist/esm/SplunkErrorInstrumentation.js.map                    
npm notice 2.0kB  dist/esm/SplunkExporter.d.ts                                  
npm notice 5.7kB  dist/esm/SplunkExporter.js                                    
npm notice 4.6kB  dist/esm/SplunkExporter.js.map                                
npm notice 260B   dist/esm/SplunkFetchInstrumentation.d.ts                      
npm notice 1.8kB  dist/esm/SplunkFetchInstrumentation.js                        
npm notice 1.0kB  dist/esm/SplunkFetchInstrumentation.js.map                    
npm notice 374B   dist/esm/SplunkLongTaskInstrumentation.d.ts                   
npm notice 3.3kB  dist/esm/SplunkLongTaskInstrumentation.js                     
npm notice 2.5kB  dist/esm/SplunkLongTaskInstrumentation.js.map                 
npm notice 393B   dist/esm/SplunkPageVisibilityInstrumentation.d.ts             
npm notice 1.9kB  dist/esm/SplunkPageVisibilityInstrumentation.js               
npm notice 1.4kB  dist/esm/SplunkPageVisibilityInstrumentation.js.map           
npm notice 798B   dist/esm/SplunkPostDocLoadResourceInstrumentation.d.ts        
npm notice 4.9kB  dist/esm/SplunkPostDocLoadResourceInstrumentation.js          
npm notice 3.6kB  dist/esm/SplunkPostDocLoadResourceInstrumentation.js.map      
npm notice 1.7kB  dist/esm/SplunkSocketIoClientInstrumentation.d.ts             
npm notice 8.0kB  dist/esm/SplunkSocketIoClientInstrumentation.js               
npm notice 5.8kB  dist/esm/SplunkSocketIoClientInstrumentation.js.map           
npm notice 494B   dist/esm/SplunkSpanAttributesProcessor.d.ts                   
npm notice 1.5kB  dist/esm/SplunkSpanAttributesProcessor.js                     
npm notice 912B   dist/esm/SplunkSpanAttributesProcessor.js.map                 
npm notice 1.1kB  dist/esm/SplunkUserInteractionInstrumentation.d.ts            
npm notice 5.2kB  dist/esm/SplunkUserInteractionInstrumentation.js              
npm notice 3.8kB  dist/esm/SplunkUserInteractionInstrumentation.js.map          
npm notice 716B   dist/esm/SplunkWebSocketInstrumentation.d.ts                  
npm notice 9.1kB  dist/esm/SplunkWebSocketInstrumentation.js                    
npm notice 6.8kB  dist/esm/SplunkWebSocketInstrumentation.js.map                
npm notice 201B   dist/esm/SplunkWebTracerProvider.d.ts                         
npm notice 1.3kB  dist/esm/SplunkWebTracerProvider.js                           
npm notice 617B   dist/esm/SplunkWebTracerProvider.js.map                       
npm notice 276B   dist/esm/SplunkXhrPlugin.d.ts                                 
npm notice 2.7kB  dist/esm/SplunkXhrPlugin.js                                   
npm notice 1.5kB  dist/esm/SplunkXhrPlugin.js.map                               
npm notice 230B   dist/esm/synthetics.d.ts                                      
npm notice 731B   dist/esm/synthetics.js                                        
npm notice 246B   dist/esm/synthetics.js.map                                    
npm notice 170B   dist/esm/upstream/user-interaction/enums/AttributeNames.d.ts  
npm notice 988B   dist/esm/upstream/user-interaction/enums/AttributeNames.js    
npm notice 348B   dist/esm/upstream/user-interaction/enums/AttributeNames.js.map
npm notice 3.0kB  dist/esm/upstream/user-interaction/instrumentation.d.ts       
npm notice 12.9kB dist/esm/upstream/user-interaction/instrumentation.js         
npm notice 8.9kB  dist/esm/upstream/user-interaction/instrumentation.js.map     
npm notice 193B   dist/esm/upstream/user-interaction/internal-types.d.ts        
npm notice 779B   dist/esm/upstream/user-interaction/internal-types.js          
npm notice 194B   dist/esm/upstream/user-interaction/internal-types.js.map      
npm notice 826B   dist/esm/upstream/user-interaction/types.d.ts                 
npm notice 685B   dist/esm/upstream/user-interaction/types.js                   
npm notice 172B   dist/esm/upstream/user-interaction/types.js.map               
npm notice 41B    dist/esm/upstream/user-interaction/version.d.ts               
npm notice 770B   dist/esm/upstream/user-interaction/version.js                 
npm notice 229B   dist/esm/upstream/user-interaction/version.js.map             
npm notice 2.1kB  dist/esm/utils.d.ts                                           
npm notice 4.4kB  dist/esm/utils.js                                             
npm notice 2.9kB  dist/esm/utils.js.map                                         
npm notice 41B    dist/esm/version.d.ts                                         
npm notice 686B   dist/esm/version.js                                           
npm notice 184B   dist/esm/version.js.map                                       
npm notice 124B   dist/esm/webvitals.d.ts                                       
npm notice 1.5kB  dist/esm/webvitals.js                                         
npm notice 1.2kB  dist/esm/webvitals.js.map                                     
npm notice 5.3kB  package.json                                                  
npm notice === Tarball Details === 
npm notice name:          @splunk/otel-web                        
npm notice version:       0.17.0-beta.0                           
npm notice filename:      splunk-otel-web-0.17.0-beta.0.tgz       
npm notice package size:  71.7 kB                                 
npm notice unpacked size: 526.9 kB                                
npm notice shasum:        4dc73e55f24dbefc64eff967bfaee2abf1fa4854
npm notice integrity:     sha512-JthRiifyj0rV0[...]nr95fQ8GHW2QA==
npm notice total files:   189                                     
npm notice 
splunk-otel-web-0.17.0-beta.0.tgz

@t2t2 t2t2 requested review from a team as code owners December 11, 2023 10:41
@t2t2 t2t2 merged commit 0a71a5c into main Dec 11, 2023
6 checks passed
@t2t2 t2t2 deleted the fix-pack-folders branch December 11, 2023 10:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seemk seemk seemk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t2t2 @seemk