Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate code base to typescript #169

Closed
wants to merge 28 commits into from
Closed

Conversation

frontendphil
Copy link
Contributor

@frontendphil frontendphil commented Oct 1, 2020

BREAKING CHANGE

position and align properties have become tuples instead of a string because type safety and we've been splitting the string anyways everywhere.

@vercel
Copy link

vercel bot commented Oct 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/signavio/react-stick/a2b4pkq0w
✅ Preview: https://react-stick-git-improvement-typescript.signavio.vercel.app

[Deployment for c7ca61b failed]

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #169 into master will decrease coverage by 1.19%.
The diff coverage is 97.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   96.09%   94.90%   -1.20%     
==========================================
  Files          13       24      +11     
  Lines         282      706     +424     
  Branches        0       92      +92     
==========================================
+ Hits          271      670     +399     
- Misses         11       12       +1     
- Partials        0       24      +24     
Impacted Files Coverage Δ
src/hooks/index.ts 100.00% <ø> (ø)
src/hooks/useWatcher.ts 93.75% <ø> (ø)
src/utils/index.ts 100.00% <ø> (ø)
src/utils/uniqueId.ts 100.00% <ø> (ø)
src/StickInline.tsx 93.75% <91.66%> (ø)
tests/positioning.test.tsx 93.54% <93.54%> (ø)
src/Stick.tsx 91.50% <94.73%> (ø)
tests/nodeWidth.test.tsx 96.29% <96.29%> (ø)
tests/updates.test.tsx 97.87% <97.87%> (ø)
src/StickContext.ts 100.00% <100.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08cc83...c635bde. Read the comment docs.

@frontendphil
Copy link
Contributor Author

@jfschwarz sorry for the huge PR :) I needed a project to test out what "migrating to typescript" means.

@Jianrong-Yu
Copy link
Contributor

A new PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants