-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate code base to typescript #169
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/signavio/react-stick/a2b4pkq0w [Deployment for c7ca61b failed] |
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
- Coverage 96.09% 94.90% -1.20%
==========================================
Files 13 24 +11
Lines 282 706 +424
Branches 0 92 +92
==========================================
+ Hits 271 670 +399
- Misses 11 12 +1
- Partials 0 24 +24
Continue to review full report at Codecov.
|
@jfschwarz sorry for the huge PR :) I needed a project to test out what "migrating to typescript" means. |
3b0f712
to
c635bde
Compare
BREAKING CHANGE: position and align strings now have to be tuples
c635bde
to
e3cb97b
Compare
A new PR is merged. |
BREAKING CHANGE
position
andalign
properties have become tuples instead of a string because type safety and we've been splitting the string anyways everywhere.